fix(calendar-list): restrict calendar visibility toggle to checkbox only #6681
Conversation
zophiana
requested review from
SebastianKrupinski,
st3iny and
tcitworld
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6681 +/- ##
============================================
+ Coverage 23.00% 28.78% +5.78%
- Complexity 475 950 +475
============================================
Files 252 294 +42
Lines 12112 14395 +2283
Branches 2310 2307 -3
============================================
+ Hits 2786 4144 +1358
- Misses 8999 9924 +925
Partials 327 327
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/components/AppNavigation/CalendarList/PublicCalendarListItem.vue
Outdated
Show resolved
Hide resolved
st3iny
added
bug
design
zophiana
force-pushed
the
fix/3027-calendar-visibility-toggle
branch
from
a7138e2 to
de1a467
Compare
I was wondering about this too, thanks for you're quick response and feedback |
Previously, clicking anywhere on the calendar name would toggle its visibility, leading to accidental hiding of calendars. Now the visibility can only be toggled by clicking the checkbox/bullet icon. Fixes nextcloud#3027 Signed-off-by: Antonia Schwennesen <[email protected]>
The enabled state cannot be persisted in public views, so the toggle functionality should not be available. Remove click handler from bullet icon to prevent misleading interaction. Co-authored-by: Richard Steinmetz <[email protected]> Signed-off-by: Antonia Schwennesen <[email protected]>
zophiana
force-pushed
the
fix/3027-calendar-visibility-toggle
branch
from
de1a467 to
8fb5f97
Compare
|
/backport to stable5.1 |
|
/backport to stable5.0 |
backportbot
bot
added
the
backport-request
st3iny
added
4. to release
backportbot
bot
removed
the
backport-request
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Previously, clicking anywhere on the calendar name would toggle its visibility, leading to accidental hiding of calendars. Now the visibility can only be toggled by clicking the checkbox/bullet icon.
Fixes #3027